RESOLVED FIXED265719
HTMLDocument::isCaseSensitiveAttribute() misses direction attribute 
https://bugs.webkit.org/show_bug.cgi?id=265719
Summary HTMLDocument::isCaseSensitiveAttribute() misses direction attribute
Ahmad Saleem
Reported 2023-12-02 06:40:49 PST
Hi Team, While looking into Blink source and then comparing it WebKit, I noticed that we don't have 'direction' (of HTML Marquee - I know I know) as case sensitive selector. I was not able to find Web-spec reference, so I went to 'Anne' (HTML Champion), if he can help and he did. Web-Spec: https://html.spec.whatwg.org/#case-sensitivity-of-selectors WebKit Source: https://github.com/WebKit/WebKit/blob/b10105f3d6b7e01e12f1c141a0aebc023f2324c9/Source/WebCore/html/HTMLDocument.cpp#L184 We need to add direction (&directionAttr,) in alphabetical order. Failing Test (again thanks to Anne) - data:text/html,<style>marquee[direction=left]{background:lime}</style><marquee%20direction=LEFT>BLAH</marquee> ^ We don't get 'lime' color but Blink does. Just raising so we can fix it. @Anne - Thanks for your help as always. Appreciate it. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Karl Dubost
Comment 1 2023-12-07 20:11:54 PST
Probably it would be good to add a WPT test for it too. Maybe in https://wpt.fyi/results/css/selectors/attribute-selectors/attribute-case/syntax.html
Radar WebKit Bug Importer
Comment 2 2023-12-09 06:41:12 PST
<rdar://problem/119432066>
Anne van Kesteren
Comment 3 2023-12-18 07:21:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/21966
EWS
Comment 4 2023-12-18 08:50:15 PST
Committed 272219@main (629d6a1da6c4): <https://commits.webkit.org/272219@main> Reviewed commits have been landed. Closing PR #21966 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.