Bug 265711 - [WebRTC] RtpPacketizer::SplitAboutEqually() should return an empty std::vector when payload_len is 0
Summary: [WebRTC] RtpPacketizer::SplitAboutEqually() should return an empty std::vecto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-01 18:05 PST by David Kilzer (:ddkilzer)
Modified: 2023-12-04 08:33 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-12-01 18:05:44 PST 
[WebRTC] RtpPacketizer::SplitAboutEqually() should return an empty std::vector when payload_len is 0.

Currently it returns a std::vector<int> with a single value of 0, which causes various ::NumPackets() methods to incorrectly return 1 instead of 0.

<rdar://119058459>
Comment 1 David Kilzer (:ddkilzer) 2023-12-02 08:03:13 PST 
<rdar://119073448>
Comment 2 David Kilzer (:ddkilzer) 2023-12-02 08:08:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21210
Comment 3 EWS 2023-12-04 08:33:56 PST 
Committed 271481@main (1838f3eb70b2): <https://commits.webkit.org/271481@main>

Reviewed commits have been landed. Closing PR #21210 and removing active labels.