Bug 265673 - [scroll-animations] WPT test scroll-animations/css/view-timeline-shorthand.html has incorrect contraction tests
Summary: [scroll-animations] WPT test scroll-animations/css/view-timeline-shorthand.ht...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 265668
  Show dependency tree / graph
 
Reported: 2023-12-01 09:04 PST by Antoine Quint
Modified: 2023-12-01 11:00 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-12-01 09:04:08 PST 
There are three tests at the end of the WPT test scroll-animations/css/view-timeline-shorthand.html:

```
test_shorthand_contraction('view-timeline', {
  'view-timeline-name': '--a, --b, --c',
  'view-timeline-axis': 'inline, inline',
  'view-timeline-inset': 'auto, auto',
}, '');

test_shorthand_contraction('view-timeline', {
  'view-timeline-name': '--a, --b',
  'view-timeline-axis': 'inline, inline, inline',
  'view-timeline-inset': 'auto, auto, auto',
}, '');

test_shorthand_contraction('view-timeline', {
  'view-timeline-name': '--a, --b',
  'view-timeline-axis': 'inline, inline',
  'view-timeline-inset': 'auto, auto, auto',
}, '');
```

These are wrong in the same way that the equivalent `scroll-timeline` shorthand tests were and which got fixed in 271190@main after discussion at https://github.com/web-platform-tests/wpt/issues/43336. Indeed, the computed value should trim the longhands to match the length of `view-timeline-name`.
Comment 1 Antoine Quint 2023-12-01 09:07:52 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21166
Comment 2 Antoine Quint 2023-12-01 09:41:43 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43478
Comment 3 EWS 2023-12-01 10:59:02 PST 
Committed 271397@main (3ec49d8dfd30): <https://commits.webkit.org/271397@main>

Reviewed commits have been landed. Closing PR #21166 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-12-01 11:00:17 PST 
<rdar://problem/119041818>