Bug 265639 - [WPE] WPE Platform: add monitors API
Summary: [WPE] WPE Platform: add monitors API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords:
Depends on:
Blocks: WPEPlatformAPI
  Show dependency treegraph
 
Reported: 2023-12-01 01:39 PST by Carlos Garcia Campos
Modified: 2024-02-06 05:26 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-12-01 01:39:13 PST
.
Comment 1 Carlos Garcia Campos 2024-01-19 02:46:35 PST
Pull request: https://github.com/WebKit/WebKit/pull/22969
Comment 2 EWS 2024-02-05 03:29:25 PST
Committed 274090@main (fda621667991): <https://commits.webkit.org/274090@main>

Reviewed commits have been landed. Closing PR #22969 and removing active labels.
Comment 3 Diego Pino 2024-02-05 08:58:48 PST
After this change WPE-Linux-64-bit-Release-Ubuntu-2004-Build is failing with the following error:

```
[295/340] Linking CXX shared library lib/libWPEWebKit-1.0.so.3.23.0
FAILED: lib/libWPEWebKit-1.0.so.3.23.0 
: && /bin/g++-10 -fPIC -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-uninitialized -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG  -Wl,--no-undefined -L/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/DependenciesWPE/Root/lib -Wl,--disable-new-dtags -shared -Wl,-soname,libWPEWebKit-1.0.so.3 -o lib/libWPEWebKit-1.0.so.3.23.0 @CMakeFiles/WebKit.rsp  && :
Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-30.cpp.o:UnifiedSource-54928a2b-30.cpp:function WebKit::WebProcess::setScreenProperties(WebCore::ScreenProperties const&): error: undefined reference to 'WebCore::setScreenProperties(WebCore::ScreenProperties const&)'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
Comment 4 Diego Pino 2024-02-05 09:00:46 PST
Re-opening for pull request https://github.com/webkit/webkit/pull/23862
Comment 5 EWS 2024-02-06 05:26:13 PST
Committed 274140@main (f7d58e8aeda0): <https://commits.webkit.org/274140@main>

Reviewed commits have been landed. Closing PR #23862 and removing active labels.