Bug 26558 - [fixup-needed] WINCE needs important date related symbols
: [fixup-needed] WINCE needs important date related symbols
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 528+ (Nightly build)
: Other Other
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 23154
  Show dependency treegraph
 
Reported: 2009-06-19 12:47 PDT by Adam Treat
Modified: 2009-08-02 01:05 PDT (History)
2 users (show)

See Also:


Attachments
Rectify (2.34 KB, patch)
2009-06-19 12:48 PDT, Adam Treat
staikos: review+
Details | Formatted Diff | Diff
patch to DateMath.cpp (1.30 KB, patch)
2009-07-30 12:47 PDT, Joe Mason
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2009-06-19 12:47:32 PDT
Hi,

The date functions in DateConstructor and DatePrototype rely upon the symbols 'time' and 'strftime' which are not available under WINCE proper.  Rather they are provided by libce.
Comment 1 Adam Treat 2009-06-19 12:48:37 PDT
Created attachment 31560 [details]
Rectify
Comment 2 George Staikos 2009-06-19 12:50:27 PDT
Comment on attachment 31560 [details]
Rectify

We should enhance our strftime to support # later and remove the formatting hack.
Comment 3 Adam Treat 2009-06-19 13:10:40 PDT
Landed with r44866.
Comment 4 Darin Adler 2009-06-19 15:57:47 PDT
Comment on attachment 31560 [details]
Rectify

Normally we put these kinds of workarounds into header files. For example, this is what MathExtras.h is for.

Also, is there really no WinCE system header file to include to get these?
Comment 5 Yong Li 2009-06-22 11:39:29 PDT
(In reply to comment #4)
> (From update of attachment 31560 [details] [review])
> Normally we put these kinds of workarounds into header files. For example, this
> is what MathExtras.h is for.
> 
> Also, is there really no WinCE system header file to include to get these?
> 

Really no. C runtime on WINCE doesn't contain these functions. This is why we need to provide a WINCE implementation for them.
Comment 6 George Staikos 2009-07-30 12:29:27 PDT
A patch was missed apparently.
Comment 7 Joe Mason 2009-07-30 12:47:59 PDT
Created attachment 33806 [details]
patch to DateMath.cpp 

DateMath.cpp also uses time symbols that have no header file on WinCE
Comment 8 George Staikos 2009-07-30 12:49:46 PDT
Comment on attachment 33806 [details]
patch to DateMath.cpp 


> +#if PLATFORM(WINCE) && ! PLATFORM(QT)

  Maybe remove that extra space on checkin
Comment 9 Adam Barth 2009-08-02 01:05:37 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/DateMath.cpp
Committed r46692
	M	JavaScriptCore/wtf/DateMath.cpp
	M	JavaScriptCore/ChangeLog
r46692 = 63611919366d757b9062c49340f72b14c7a06f32 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46692