Bug 26558 – [fixup-needed] WINCE needs important date related symbols

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Adam Treat]

Hi,

The date functions in DateConstructor and DatePrototype rely upon the symbols 'time' and 'strftime' which are not available under WINCE proper.  Rather they are provided by libce.

[Adam Treat]

Created attachment 31560 [details]
Rectify

[George Staikos]

Comment on attachment 31560 [details]
Rectify

We should enhance our strftime to support # later and remove the formatting hack.

[Adam Treat]

Landed with r44866.

[Darin Adler]

Comment on attachment 31560 [details]
Rectify

Normally we put these kinds of workarounds into header files. For example, this is what MathExtras.h is for.

Also, is there really no WinCE system header file to include to get these?

[Yong Li]

(In reply to comment #4)
> (From update of attachment 31560 [details] [review])
> Normally we put these kinds of workarounds into header files. For example, this
> is what MathExtras.h is for.
> 
> Also, is there really no WinCE system header file to include to get these?
> 

Really no. C runtime on WINCE doesn't contain these functions. This is why we need to provide a WINCE implementation for them.

[George Staikos]

A patch was missed apparently.

[Joe Mason]

Created attachment 33806 [details]
patch to DateMath.cpp 

DateMath.cpp also uses time symbols that have no header file on WinCE

[George Staikos]

Comment on attachment 33806 [details]
patch to DateMath.cpp 


> +#if PLATFORM(WINCE) && ! PLATFORM(QT)

  Maybe remove that extra space on checkin

[Adam Barth]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/DateMath.cpp
Committed r46692
	M	JavaScriptCore/wtf/DateMath.cpp
	M	JavaScriptCore/ChangeLog
r46692 = 63611919366d757b9062c49340f72b14c7a06f32 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46692