Hi, The date functions in DateConstructor and DatePrototype rely upon the symbols 'time' and 'strftime' which are not available under WINCE proper. Rather they are provided by libce.
Created attachment 31560 [details] Rectify
Comment on attachment 31560 [details] Rectify We should enhance our strftime to support # later and remove the formatting hack.
Landed with r44866.
Comment on attachment 31560 [details] Rectify Normally we put these kinds of workarounds into header files. For example, this is what MathExtras.h is for. Also, is there really no WinCE system header file to include to get these?
(In reply to comment #4) > (From update of attachment 31560 [details] [review]) > Normally we put these kinds of workarounds into header files. For example, this > is what MathExtras.h is for. > > Also, is there really no WinCE system header file to include to get these? > Really no. C runtime on WINCE doesn't contain these functions. This is why we need to provide a WINCE implementation for them.
A patch was missed apparently.
Created attachment 33806 [details] patch to DateMath.cpp DateMath.cpp also uses time symbols that have no header file on WinCE
Comment on attachment 33806 [details] patch to DateMath.cpp > +#if PLATFORM(WINCE) && ! PLATFORM(QT) Maybe remove that extra space on checkin
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/DateMath.cpp Committed r46692 M JavaScriptCore/wtf/DateMath.cpp M JavaScriptCore/ChangeLog r46692 = 63611919366d757b9062c49340f72b14c7a06f32 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46692