RESOLVED FIXED 265557
Reference being taken to SourceBufferPrivateAVFObjC in destructor 
https://bugs.webkit.org/show_bug.cgi?id=265557
Summary Reference being taken to SourceBufferPrivateAVFObjC in destructor
Jean-Yves Avenard [:jya]
Reported 2023-11-29 17:03:04 PST
In bug 265274, WeakPtr were changed to ThreadSafeWeakPtr meaning that the code now take a RefPtr whenever calling _parent.get() which is in the middle of being destructed [1] There's no need to check if the _parent is still alive in the invalidate method as parent isn't referenced. [1] https://searchfox.org/wubkat/rev/c20f54808bd9cd41e49a640e8c20923340e4d14b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm#138-141
Attachments
Add attachment proposed patch, testcase, etc.
Jean-Yves Avenard [:jya]
Comment 1 2023-11-29 17:03:13 PST
rdar://118957859
Jean-Yves Avenard [:jya]
Comment 2 2023-11-29 17:05:24 PST
Pull request: https://github.com/WebKit/WebKit/pull/21085
EWS
Comment 3 2023-11-29 20:25:23 PST
Committed 271325@main (0769c4423a3f): <https://commits.webkit.org/271325@main> Reviewed commits have been landed. Closing PR #21085 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.