Bug 265557 - Reference being taken to SourceBufferPrivateAVFObjC in destructor
Summary: Reference being taken to SourceBufferPrivateAVFObjC in destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-29 17:03 PST by Jean-Yves Avenard [:jya]
Modified: 2023-11-29 20:25 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-11-29 17:03:04 PST 
In bug 265274, WeakPtr were changed to ThreadSafeWeakPtr meaning that the code now take a RefPtr whenever calling _parent.get() which is in the middle of being destructed [1]

There's no need to check if the _parent is still alive in the invalidate method as parent isn't referenced.


[1] https://searchfox.org/wubkat/rev/c20f54808bd9cd41e49a640e8c20923340e4d14b/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm#138-141
Comment 1 Jean-Yves Avenard [:jya] 2023-11-29 17:03:13 PST 
rdar://118957859
Comment 2 Jean-Yves Avenard [:jya] 2023-11-29 17:05:24 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21085
Comment 3 EWS 2023-11-29 20:25:23 PST 
Committed 271325@main (0769c4423a3f): <https://commits.webkit.org/271325@main>

Reviewed commits have been landed. Closing PR #21085 and removing active labels.