Bug 26552 - JS bindings for HTMLAudioElement
Summary: JS bindings for HTMLAudioElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-19 11:26 PDT by Kyle Prete
Modified: 2009-06-22 14:03 PDT (History)
1 user (show)

See Also:

Attachments
change to V8CustomBinding.h (23.70 KB, patch)
2009-06-19 11:31 PDT, Kyle Prete 		no flags Details | Formatted Diff | Diff
new file necessary (2.81 KB, patch)
2009-06-19 11:32 PDT, Kyle Prete 		dglazkov: review-
Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2009-06-19 11:38 PDT, Kyle Prete 		dglazkov: review-
Details | Formatted Diff | Diff
Patch (3.84 KB, patch)
2009-06-19 11:46 PDT, Kyle Prete 		dglazkov: review-
Details | Formatted Diff | Diff
Patch (4.49 KB, patch)
2009-06-19 11:56 PDT, Kyle Prete 		dglazkov: review-
Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2009-06-19 14:22 PDT, Kyle Prete 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Prete 2009-06-19 11:26:50 PDT 
WebKit/WebCore/bindings/v8/custom/V8CustomBinding.h needs DECLARE_CALLBACK(HTMLAudioElementConstructor);

WebKit/WebCore/bindings/v8/custom/ needs a .cpp file for V8HTMLAudioElementConstructor
Comment 1 Kyle Prete 2009-06-19 11:31:59 PDT 
Created attachment 31551 [details]
change to V8CustomBinding.h
Comment 2 Kyle Prete 2009-06-19 11:32:35 PDT 
Created attachment 31552 [details]
new file necessary
Comment 3 Dimitri Glazkov (Google) 2009-06-19 11:35:16 PDT 
Please read http://webkit.org/coding/contributing.html for guidelines on submitting patches.
Comment 4 Kyle Prete 2009-06-19 11:38:50 PDT 
Created attachment 31553 [details]
Patch
Comment 5 Dimitri Glazkov (Google) 2009-06-19 11:43:09 PDT 
Comment on attachment 31553 [details]
Patch

Need a ChangeLog entry.

> +    if (args.Length() > 0) {
> +        audio->setSrc(toWebCoreString(args[0]));
> +    }

No braces for one-liners.
Comment 6 Kyle Prete 2009-06-19 11:46:23 PDT 
Created attachment 31554 [details]
Patch
Comment 7 Dimitri Glazkov (Google) 2009-06-19 11:48:33 PDT 
Comment on attachment 31554 [details]
Patch

Don't rush :) Still need a ChangeLog entry.
Comment 8 Kyle Prete 2009-06-19 11:56:28 PDT 
Created attachment 31556 [details]
Patch

My bad. Didn't understand what you meant.
Comment 9 Dimitri Glazkov (Google) 2009-06-19 14:16:19 PDT 
Comment on attachment 31556 [details]
Patch

Sorry, spoke too soon -- need bug URL in ChangeLog.
Comment 10 Kyle Prete 2009-06-19 14:22:54 PDT 
Created attachment 31564 [details]
Patch
Comment 11 Dimitri Glazkov (Google) 2009-06-19 14:26:24 PDT 
Comment on attachment 31564 [details]
Patch

Beautiful.
Comment 12 David Levin 2009-06-22 13:26:13 PDT 
Assigned to levin for landing.
Comment 13 David Levin 2009-06-22 14:03:39 PDT 
Committed as http://trac.webkit.org/changeset/44953