NEW 265442
[TextureMapper] Remove TextureMapperGLHeaders.h
https://bugs.webkit.org/show_bug.cgi?id=265442
Summary [TextureMapper] Remove TextureMapperGLHeaders.h
Carlos Garcia Campos
Reported 2023-11-28 01:44:50 PST
Just include the GL headers from cpp files only, since it can conflict between epoxy, angle and system headers.
Attachments
Carlos Garcia Campos
Comment 1 2023-11-28 01:47:22 PST
Carlos Garcia Campos
Comment 2 2023-11-29 00:39:13 PST
Grouping the includes in a single header is not the problem, it just makes easier to make a mistake and include the common header from another header. For example, in angle we have ANGLEHeaders.h and it's not a problem as long as it's only included from cpp files and not unified with others, see the comment in the header: // Note: this file can't be compiled in the same unified source file // as others which include the system's OpenGL headers. I can keep the common header if you prefer, but we need to make sure it's never included in headers and cpp files including it are not unified.
Radar WebKit Bug Importer
Comment 3 2023-12-05 01:45:16 PST
Note You need to log in before you can comment on or make changes to this bug.