Bug 265442 - [TextureMapper] Remove TextureMapperGLHeaders.h
Summary: [TextureMapper] Remove TextureMapperGLHeaders.h
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2023-11-28 01:44 PST by Carlos Garcia Campos
Modified: 2023-12-05 01:45 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-11-28 01:44:50 PST 
Just include the GL headers from cpp files only, since it can conflict between epoxy, angle and system headers.
Comment 1 Carlos Garcia Campos 2023-11-28 01:47:22 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20983
Comment 2 Carlos Garcia Campos 2023-11-29 00:39:13 PST 
Grouping the includes in a single header is not the problem, it just makes easier to make a mistake and include the common header from another header. For example, in angle we have ANGLEHeaders.h and it's not a problem as long as it's only included from cpp files and not unified with others, see the comment in the header:

// Note: this file can't be compiled in the same unified source file                                                                                                                          
// as others which include the system's OpenGL headers.

I can keep the common header if you prefer, but we need to make sure it's never included in headers and cpp files including it are not unified.
Comment 3 Radar WebKit Bug Importer 2023-12-05 01:45:16 PST 
<rdar://problem/119176822>