Bug 265411 – Sync 'resizeBy' and 'resizeTo' with CSSOM-View WebIDL Specification

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ahmad Saleem]

Hi Team,

While looking into 'browser specific failures' on WPT, I noticed that we fail few test cases 'cssom-view\idlharness.html' around 'resizeBy' and 'resizeTo':

WPT Test Case: https://wpt.fyi/results/css/cssom-view/idlharness.html?label=master&label=experimental&aligned&q=safari:fail

Web-Specification: https://www.w3.org/TR/cssom-view-1/#extensions-to-the-window-interface

By doing changes in 'LocalDOMWindow' and 'Source/WebCore/page/LocalDOMWindow+CSSOMView.idl', I was able to progress few of them but I am not sure whether it is intentional to hold-off so I just wanted to raise bug.

>> Source/WebCore/page/LocalDOMWindow+CSSOMView.idl:


From:

undefined resizeTo(optional unrestricted float width = NaN, optional unrestricted float height = NaN); // Parameters should be mandatory and of type long.
undefined resizeBy(optional unrestricted float x = NaN, optional unrestricted float y = NaN); // FIXME: Parameters should be mandatory and of type long.


To:

undefined resizeTo(long width, long height);
undefined resizeBy(long x, long y);


>>

https://github.com/WebKit/WebKit/blob/1e3555d85962434a8f26aae28cd16815ab5412b8/Source/WebCore/page/LocalDOMWindow.cpp#L1865 etc.

^ I haven't tested it locally or tried but just thought to raise it.

__


Just wanted to raise so we can fix it. Adding 'BrowserCompat' tag since only WebKit / Safari is failing them and 'WPTImpact' because it has impact on WPT.

Thanks!

[EWS]

Committed 271194@main (99f5a390d9b4): <https://commits.webkit.org/271194@main>

Reviewed commits have been landed. Closing PR #20964 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/118872048>