Bug 26540 - Modify SunSpider and jsc test shell to add a parsing only test suite
Summary: Modify SunSpider and jsc test shell to add a parsing only test suite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-19 07:49 PDT by Adam Treat
Modified: 2009-09-21 13:25 PDT (History)
0 users

See Also:


Attachments
Add a new testsuite for parsing performance to SunSpider and jsc.cpp (715.73 KB, patch)
2009-06-19 07:56 PDT, Adam Treat
oliver: review-
Details | Formatted Diff | Diff
Cleaned up patch taking into account Oliver's comment (717.44 KB, patch)
2009-06-19 11:56 PDT, Adam Treat
no flags Details | Formatted Diff | Diff
Change the docs in the ChangeLog to reflect 'checkSyntax' addition (717.37 KB, patch)
2009-06-19 12:00 PDT, Adam Treat
oliver: review+
Details | Formatted Diff | Diff
proposed patch (2.09 KB, patch)
2009-09-21 05:49 PDT, Csaba Osztrogonác
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Treat 2009-06-19 07:49:35 PDT
Hi,

Currently the SunSpider test driver lacks an option to run a test suite that will test parsing performance only.  Attached you'll find a patch that adds just such a test suite and option to SunSpider and the jsc test shell.  I've included three large javascript source files found in the wild: jquery, mootools and prototype.  Together and combined with the concatenation of all three, these form a new testsuite to measure and test pure parsing performance.

Cheers.
Comment 1 Adam Treat 2009-06-19 07:56:56 PDT
Created attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp
Comment 2 Oliver Hunt 2009-06-19 11:25:57 PDT
Comment on attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp

This shouldn't add new commandline arguments to jsc unless they have general case value.

I would make the parser test be
parser.js:
checkSyntax("parser-test-sources.js")
Comment 3 Adam Treat 2009-06-19 11:56:23 PDT
Created attachment 31555 [details]
Cleaned up patch taking into account Oliver's comment
Comment 4 Adam Treat 2009-06-19 12:00:37 PDT
Created attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition
Comment 5 Oliver Hunt 2009-06-19 12:28:32 PDT
Comment on attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition

missing a new line at the end of a couple of the files, correct those and r=me
Comment 6 Adam Treat 2009-06-19 13:57:56 PDT
Landed with 44870.
Comment 7 Csaba Osztrogonác 2009-09-21 05:49:42 PDT
Created attachment 39847 [details]
proposed patch

The patch landed in http://trac.webkit.org/changeset/44870 works correctly, but if you run WebKitTools/Scripts/run-sunspider, it doesn't pass the --parse-only parameter to SunSpider/sunspider script.
Comment 8 Eric Seidel (no email) 2009-09-21 13:25:47 PDT
Comment on attachment 39847 [details]
proposed patch

Please file a new bug for this patch.