Bug 26540 – Modify SunSpider and jsc test shell to add a parsing only test suite

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Treat]

Hi,

Currently the SunSpider test driver lacks an option to run a test suite that will test parsing performance only.  Attached you'll find a patch that adds just such a test suite and option to SunSpider and the jsc test shell.  I've included three large javascript source files found in the wild: jquery, mootools and prototype.  Together and combined with the concatenation of all three, these form a new testsuite to measure and test pure parsing performance.

Cheers.

[Adam Treat]

Created attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp

[Oliver Hunt]

Comment on attachment 31544 [details]
Add a new testsuite for parsing performance to SunSpider and jsc.cpp

This shouldn't add new commandline arguments to jsc unless they have general case value.

I would make the parser test be
parser.js:
checkSyntax("parser-test-sources.js")

[Adam Treat]

Created attachment 31555 [details]
Cleaned up patch taking into account Oliver's comment

[Adam Treat]

Created attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition

[Oliver Hunt]

Comment on attachment 31558 [details]
Change the docs in the ChangeLog to reflect 'checkSyntax' addition

missing a new line at the end of a couple of the files, correct those and r=me

[Adam Treat]

Landed with 44870.

[Csaba Osztrogonác]

Created attachment 39847 [details]
proposed patch

The patch landed in http://trac.webkit.org/changeset/44870 works correctly, but if you run WebKitTools/Scripts/run-sunspider, it doesn't pass the --parse-only parameter to SunSpider/sunspider script.

[Eric Seidel (no email)]

Comment on attachment 39847 [details]
proposed patch

Please file a new bug for this patch.