Bug 265381 - Web Inspector: CSS Grid Page Overlay support for masonry layout
Summary: Web Inspector: CSS Grid Page Overlay support for masonry layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar
Depends on:
Blocks: 265382 265383
  Show dependency tree / graph
 
Reported: 2023-11-27 07:51 PST by Razvan Caliman
Modified: 2023-11-30 04:07 PST (History)
3 users (show)

See Also:

Attachments
Screenshot of issue (1.61 MB, image/png)
2023-11-27 07:52 PST, Razvan Caliman 		no flags Details
Screenshot with patch applied (1.64 MB, image/png)
2023-11-27 08:22 PST, Razvan Caliman 		no flags Details
Test case for masonry + writing modes (4.89 KB, text/html)
2023-11-27 08:22 PST, Razvan Caliman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Razvan Caliman 2023-11-27 07:51:14 PST 
The CSS Grid Page Overlay should correctly represent lines in a masonry layout.

The CSS Grid Page Overlay is currently broken because it relies on there being grid tracks on both axes (see screenshot). Technically, there are no grid tracks in the masonry axis. Grid cells vary in dimension in the masonry axis.

The masonry layout implementation is currently behind a flag ("CSS Masonry Layout") in Safari > Settings > Feature Flags.
Comment 1 Razvan Caliman 2023-11-27 07:52:19 PST 
Created attachment 468766 [details]
Screenshot of issue
Comment 2 Razvan Caliman 2023-11-27 07:52:58 PST Comment hidden (obsolete)
Comment 3 Radar WebKit Bug Importer 2023-11-27 07:53:16 PST Comment hidden (obsolete)
Comment 4 Tim Nguyen (:ntim) 2023-11-27 08:08:55 PST 
rdar://117505876
Comment 5 Razvan Caliman 2023-11-27 08:21:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20934
Comment 6 Razvan Caliman 2023-11-27 08:22:22 PST 
Created attachment 468767 [details]
Screenshot with patch applied
Comment 7 Razvan Caliman 2023-11-27 08:22:55 PST 
Created attachment 468768 [details]
Test case for masonry + writing modes
Comment 8 EWS 2023-11-30 04:07:23 PST 
Committed 271332@main (9a3f6dd4c6a6): <https://commits.webkit.org/271332@main>

Reviewed commits have been landed. Closing PR #20934 and removing active labels.