Bug 26531 - Timezone calculation incorrect in Venezuela.
: Timezone calculation incorrect in Venezuela.
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-18 21:56 PST by
Modified: 2009-06-18 22:07 PST (History)


Attachments
The patch (2.14 KB, patch)
2009-06-18 21:58 PST, Gavin Barraclough
ggaren: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-18 21:56:53 PST
The problem is that we're calculating the timezone relative to 01/01/2000, but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.  According to the spec, section 15.9.1.9 states "the time since the beginning of the year", presumably meaning the *current* year.  Change the calculation to be based on whatever the current year is, rather than a canned date.
------- Comment #1 From 2009-06-18 21:58:48 PST -------
Created an attachment (id=31532) [details]
The patch
------- Comment #2 From 2009-06-18 22:02:48 PST -------
(From update of attachment 31532 [details])
r=me assuming all JSC tests pass
------- Comment #3 From 2009-06-18 22:07:24 PST -------
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/wtf/DateMath.cpp
Transmitting file data ..
Committed revision 44842.