Bug 265254 - Web Inspector: The `tan()` function triggers the color picker
Summary: Web Inspector: The `tan()` function triggers the color picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-22 09:28 PST by Bramus
Modified: 2023-11-24 11:23 PST (History)
4 users (show)

See Also:

Attachments
Screenshot of Web Inspector (232.93 KB, image/png)
2023-11-22 09:28 PST, Bramus 		no flags Details
Test case (187 bytes, text/html)
2023-11-22 11:03 PST, Razvan Caliman 		no flags Details
Screenshot of Web Inspector with patch applied (402.47 KB, image/png)
2023-11-22 11:04 PST, Razvan Caliman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bramus 2023-11-22 09:28:22 PST 
Created attachment 468731 [details]
Screenshot of Web Inspector

1. Visit https://codepen.io/thebabydino/pen/JjxvKLe
2. Inspect the `<html>` element (of the demo in the `<iframe>`)
3. Check the value for `--m`

Web Inspector is showing the Color Picker for it, most likely because it sees “tan” in there which is a named color.


/via https://twitter.com/anatudor/status/1727371562146533592
Comment 1 Razvan Caliman 2023-11-22 10:49:25 PST 
Well, this is embarrassing :)
Thanks for filing the issue!
Comment 2 Radar WebKit Bug Importer 2023-11-22 10:49:56 PST 
<rdar://problem/118724061>
Comment 3 Razvan Caliman 2023-11-22 11:02:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20829
Comment 4 Razvan Caliman 2023-11-22 11:03:52 PST 
Created attachment 468732 [details]
Test case
Comment 5 Razvan Caliman 2023-11-22 11:04:39 PST 
Created attachment 468733 [details]
Screenshot of Web Inspector with patch applied
Comment 6 Bramus 2023-11-23 01:12:36 PST 
> Well, this is embarrassing :)

FWIW: Chrome also affected by this 😅

Thanks for fixing this so quickly.
Comment 7 EWS 2023-11-23 03:22:13 PST 
Committed 271075@main (edd9c3ef508e): <https://commits.webkit.org/271075@main>

Reviewed commits have been landed. Closing PR #20829 and removing active labels.