Bug 265166 - [IFC] Pre-compute "content has strong directionality character" bit
Summary: [IFC] Pre-compute "content has strong directionality character" bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-20 17:09 PST by zalan
Modified: 2023-11-21 07:15 PST (History)
12 users (show)

See Also:

Attachments
Patch (16.94 KB, patch)
2023-11-20 17:58 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (17.61 KB, patch)
2023-11-21 06:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-11-20 17:09:53 PST 
ssia
Comment 1 zalan 2023-11-20 17:58:15 PST 
Created attachment 468695 [details]
Patch
Comment 2 Antti Koivisto 2023-11-21 06:02:23 PST 
Comment on attachment 468695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468695&action=review

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:37
> +InlineTextBox::InlineTextBox(String content, bool isCombined, WTF::OptionSet<ContentCharacteristic> contentCharacteristicSet, RenderStyle&& style, std::unique_ptr<RenderStyle>&& firstLineStyle)

no need to say WTF::

> Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:45
> +    InlineTextBox(String, bool isCombined, WTF::OptionSet<ContentCharacteristic>, RenderStyle&&, std::unique_ptr<RenderStyle>&& firstLineStyle = nullptr);

(anywhere)
Comment 3 zalan 2023-11-21 06:17:36 PST 
Created attachment 468709 [details]
[fast-cq]Patch
Comment 4 EWS 2023-11-21 07:14:36 PST 
Committed 271016@main (dc839aa94c04): <https://commits.webkit.org/271016@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468709 [details].
Comment 5 Radar WebKit Bug Importer 2023-11-21 07:15:15 PST 
<rdar://problem/118687678>