[GTK] Failed to create GBM buffer of size 0x0: Invalid argument

[Michael Catanzaro]

Reproducer:

 * Open two Epiphany windows. One of the two windows should have only one open tab.
 * Close the window that has only one tab.
 * Use Reopen Closed Tab to reopen the window

Expected behavior: the tab reopens and loads

Actual behavior: the tab reopens, but no web content is displayed, and this warning is printed:

Failed to create GBM buffer of size 0x0: Invalid argument

This reproducer works in both main (tested with 270652@main) and Epiphany Tech Preview (WebKitGTK 2.42.2). However, it's not 100% reliable. It *usually* fails to display web content, but not always. If it works, then it seems to always fail if I try again.

The error is coming from AcceleratedSurfaceDMABuf::RenderTargetEGLImage::create, here:

    if (!bo) {
        WTFLogAlways("Failed to create GBM buffer of size %dx%d: %s", size.width(), size.height(), safeStrerror(errno).data());
        return nullptr;
    }

I presume gbm_bo_create() does not like us trying to use 0 width and 0 height.

[Philippe Normand]

This happens here in WPE and GTK when trying to use the remote web-inspector. The newly opened window is empty.

[Philippe Normand]

This happens here in WPE and GTK when trying to use the remote web-inspector. The newly opened window is empty.

[Michael Catanzaro]

This also breaks the embedded web view in gnome-initial-setup if the web view is created more than once: https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/issues/213

[Carlos Garcia Campos]

Pull request: https://github.com/WebKit/WebKit/pull/26043

[EWS]

Committed 276337@main (c3a01735d064): <https://commits.webkit.org/276337@main>

Reviewed commits have been landed. Closing PR #26043 and removing active labels.