Bug 265128 – Build fails with libxml2 version 2.12.0 due to API change

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Adrian Perez]

The following commit made it into 2.12.0 and changed the const-ness of
xmlError pointers:

  https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711

...which results in the following build failure:

  In file included from /app/webkit/WebKitBuild/GTK/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-42f7b70e-4.cpp:6:
  /app/webkit/Source/WebCore/xml/XSLTProcessorLibxslt.cpp:131:9: error: no matching function for call to 'xmlSetStructuredErrorFunc'
          xmlSetStructuredErrorFunc(console, XSLTProcessor::parseErrorFunc);
          ^~~~~~~~~~~~~~~~~~~~~~~~~
  /usr/include/libxml2/libxml/xmlerror.h:871:5: note: candidate function not viable: no known conversion from 'void (void *, const xmlError *)' (aka 'void (void *, const _xmlError *)') to 'xmlStructuredErrorFunc' (aka 'void (*)(void *, _xmlError *)') for 2nd argument
      xmlSetStructuredErrorFunc   (void *ctx,
      ^

I have reported the bug upstream, but the developer replied that the change
is intentional, so we need to handle the difference inside WebKit.

[Adrian Perez]

Upstream bug: https://gitlab.gnome.org/GNOME/libxml2/-/issues/622

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/20741

[EWS]

Committed 270977@main (1bad176b2496): <https://commits.webkit.org/270977@main>

Reviewed commits have been landed. Closing PR #20741 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/118653269>