Bug 265101 – Make a couple more http/tests/security tests use window.internals.isFullyActive(Document&)

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[sideshowbarker]

https://commits.webkit.org/270737@main added a new window.internals.isFullyActive(Document&) function — intended for tests where it’s necessary to ensure whether or not a particular document is fully active — and used that function to update (fix) the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test, which had been flaky since it was last updated in https://commits.webkit.org/269235@main.

And in that https://commits.webkit.org/269235@main change which caused the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html test to become flaky, its companion tests at LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html and LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html had also been updated in the same way as the http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html had been before it was subsequently fixed.

And while those two other companion tests have not yet been flaky, we should also (re)update them to now use window.internals.isFullyActive(Document&) — in order to ensure they’re actually testing what they’re intended to be testing.

[sideshowbarker]

Pull request: https://github.com/WebKit/WebKit/pull/20715

[Radar WebKit Bug Importer]

<rdar://problem/118796437>

[EWS]

Committed 271565@main (a2d071de9311): <https://commits.webkit.org/271565@main>

Reviewed commits have been landed. Closing PR #20715 and removing active labels.