See: https://github.com/whatwg/html/issues/2368#issuecomment-1791704780 https://chromium-review.googlesource.com/c/chromium/src/+/5007308 https://github.com/web-platform-tests/wpt/pull/42976
<rdar://problem/118584431>
Something to do here? https://searchfox.org/wubkat/rev/114aa2c8594807cbc34dd5dff48a9e2addfd1e00/Source/WebCore/dom/EventDispatcher.cpp#160 if (node.document().settings().sendMouseEventsToDisabledFormControlsEnabled() && event.isTrusted() && event.isMouseEvent() && (event.type() == eventNames().mousedownEvent || event.type() == eventNames().mouseupEvent || event.type() == eventNames().clickEvent)) { eventPath.adjustForDisabledFormControl(); }
Adding: || event.type() == eventNames().dblclickEvent
NOTE - this compiles and after importing new tests and running on patch build, we pass all tests. @Tim - do you want me to do PR? I might do separate bug first to update all tests.
PASS Testing dblclick events when clicking child of disabled button. PASS Testing dblclick events when clicking child of disabled my-control. PASS Testing dblclick events when clicking disabled button. PASS Testing dblclick events when clicking disabled my-control. ^ All passes.
@ahmad.saleem792@gmail.com go for it. Let's start with a PR syncing `wpt:html/semantics/` and then a PR for the fix you're proposing.
Ah, spoke a minute too late, I see the WPT sync PR is up.
Committed 270951@main (74ae3ea8d68e): <https://commits.webkit.org/270951@main> Reviewed commits have been landed. Closing PR #20723 and removing active labels.