Bug 265056 - AX: Cache AccessibilityText eagerly
Summary: AX: Cache AccessibilityText eagerly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joshua Hoffman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-17 11:37 PST by Joshua Hoffman
Modified: 2023-11-27 12:30 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2023-11-17 12:07 PST, Joshua Hoffman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Hoffman 2023-11-17 11:37:44 PST 
AccessibilityText should be cached eagerly to avoid main-thread hits.
Comment 1 Radar WebKit Bug Importer 2023-11-17 11:37:53 PST 
<rdar://problem/118574320>
Comment 2 Joshua Hoffman 2023-11-17 12:07:57 PST 
Created attachment 468654 [details]
Patch
Comment 3 chris fleizach 2023-11-17 17:14:27 PST 
Comment on attachment 468654 [details]
Patch

Do you think this test is related?

    TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded
        /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded  Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"]  Actual: falseExpected: true
Comment 4 chris fleizach 2023-11-17 17:14:27 PST 
Comment on attachment 468654 [details]
Patch

Do you think this test is related?

    TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded
        /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded  Actual: falseExpected: true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"]  Actual: falseExpected: true
Comment 5 Joshua Hoffman 2023-11-17 18:11:47 PST 
(In reply to chris fleizach from comment #4)
> Comment on attachment 468654 [details]
> Patch
> 
> Do you think this test is related?
> 
>     TestWebKitAPI.AccessibilityTests.WebProcessLoaderBundleLoaded
>        
> /Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/TestWebKitAPI/
> Tests/ios/AccessibilityTestsIOS.mm:170Value of: bundleLoaded  Actual:
> falseExpected:
> true/Volumes/Data/worker/iOS-17-Simulator-Build-EWS/build/Tools/
> TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:174Value of: [loadedPath
> hasSuffix:@"/System/Library/AccessibilityBundles/WebProcessLoader.axbundle"]
> Actual: falseExpected: true

I wouldn’t think it’s related since this patch only touches the isolated tree and this is an iOS failure.
Comment 6 EWS 2023-11-27 12:30:44 PST 
Committed 271161@main (1cf46fbe9b7b): <https://commits.webkit.org/271161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468654 [details].