Bug 26502 - [Chromium] Use WebCore::multipleFileUploadText()
Summary: [Chromium] Use WebCore::multipleFileUploadText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-17 17:13 PDT by Kent Tamura
Modified: 2009-06-19 11:24 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (1.39 KB, patch)
2009-06-17 17:14 PDT, Kent Tamura 		levin: review-
Details | Formatted Diff | Diff
Proposed pattch rev.2 (1.49 KB, patch)
2009-06-18 18:41 PDT, Kent Tamura 		levin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-06-17 17:13:21 PDT 
The current code of FileChooserChoromium.cpp doesn't use multipleFileUploadText().  So if a user selects multiple files for a file upload form, Chrome shows the first filename.  It should show a text like "N files" like Safari.
Comment 1 Kent Tamura 2009-06-17 17:14:58 PDT 
Created attachment 31470 [details]
Proposed patch
Comment 2 David Levin 2009-06-18 15:52:48 PDT 
Comment on attachment 31470 [details]
Proposed patch


> Index: WebCore/ChangeLog
> +2009-06-17  Kent Tamura  <tkent@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Use WebCore::multipleFileUploadText() in Chromium.
> +        <https://bugs.webkit.org/show_bug.cgi?id=26502>
> +

Ideally you would have something about why you are doing the change here?
What does the change accomplish?  (You have this in the bug.)

This change looks good but the changelog needs to be improved, so r- until that is fixed.  With a better change log, I'd happily give it an r+.
Comment 3 Kent Tamura 2009-06-18 18:41:53 PDT 
Created attachment 31527 [details]
Proposed pattch rev.2

Thank you for the comment.  I have updated the ChangeLog.
Comment 4 David Levin 2009-06-18 18:44:19 PDT 
Comment on attachment 31527 [details]
Proposed pattch rev.2

There are tabs in the changelog.

I'll fix this on landing.
Comment 5 David Levin 2009-06-18 18:44:45 PDT 
Assigned to levin for landing.
Comment 6 David Levin 2009-06-19 11:24:04 PDT 
Committed as http://trac.webkit.org/changeset/44860