RESOLVED FIXED 26502
[Chromium] Use WebCore::multipleFileUploadText() 
https://bugs.webkit.org/show_bug.cgi?id=26502
Summary [Chromium] Use WebCore::multipleFileUploadText()
Kent Tamura
Reported 2009-06-17 17:13:21 PDT
The current code of FileChooserChoromium.cpp doesn't use multipleFileUploadText(). So if a user selects multiple files for a file upload form, Chrome shows the first filename. It should show a text like "N files" like Safari.
Attachments
Proposed patch (1.39 KB, patch)
2009-06-17 17:14 PDT, Kent Tamura 		levin: review-
DetailsFormatted DiffDiff
Proposed pattch rev.2 (1.49 KB, patch)
2009-06-18 18:41 PDT, Kent Tamura 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2009-06-17 17:14:58 PDT
Created attachment 31470 [details] Proposed patch
David Levin
Comment 2 2009-06-18 15:52:48 PDT
Comment on attachment 31470 [details] Proposed patch > Index: WebCore/ChangeLog > +2009-06-17 Kent Tamura <tkent@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Use WebCore::multipleFileUploadText() in Chromium. > + <https://bugs.webkit.org/show_bug.cgi?id=26502> > + Ideally you would have something about why you are doing the change here? What does the change accomplish? (You have this in the bug.) This change looks good but the changelog needs to be improved, so r- until that is fixed. With a better change log, I'd happily give it an r+.
Kent Tamura
Comment 3 2009-06-18 18:41:53 PDT
Created attachment 31527 [details] Proposed pattch rev.2 Thank you for the comment. I have updated the ChangeLog.
David Levin
Comment 4 2009-06-18 18:44:19 PDT
Comment on attachment 31527 [details] Proposed pattch rev.2 There are tabs in the changelog. I'll fix this on landing.
David Levin
Comment 5 2009-06-18 18:44:45 PDT
Assigned to levin for landing.
David Levin
Comment 6 2009-06-19 11:24:04 PDT
Committed as http://trac.webkit.org/changeset/44860
Note You need to log in before you can comment on or make changes to this bug.