Bug 26499 - Support hardware acceleration of <video>
Summary: Support hardware acceleration of <video>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-06-17 16:37 PDT by Simon Fraser (smfr)
Modified: 2009-06-18 11:53 PDT (History)
2 users (show)

See Also:


Attachments
Step 1 patch (12.35 KB, patch)
2009-06-17 16:57 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff
Step 2: hook up the MediaPlayer with the layer compositing system (32.04 KB, patch)
2009-06-17 18:41 PDT, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-06-17 16:37:24 PDT
We should support hardware acceleration of <video> presentation, when ACCELERATED_COMPOSITING is enabled.
Comment 1 Simon Fraser (smfr) 2009-06-17 16:57:20 PDT
Created attachment 31468 [details]
Step 1 patch
Comment 2 Simon Fraser (smfr) 2009-06-17 17:37:26 PDT
<rdar://problem/6978729>
Comment 3 Darin Adler 2009-06-17 17:53:42 PDT
Comment on attachment 31468 [details]
Step 1 patch

> +    virtual bool requiresLayer() const { return true; }
> +    virtual bool isVideo() const { return true; }

These should be private. For example, if anyone calls isVideo() on a RenderVideo you want the compile to fail so they don't create unneeded dead code.

Of course, most of the other virtual functions should be private too for the same reason.

Are those extra virtual calls in isSelfPaintingLayer() getting out of hand?

r=me
Comment 4 Simon Fraser (smfr) 2009-06-17 18:41:49 PDT
Created attachment 31481 [details]
Step 2: hook up the MediaPlayer with the layer compositing system
Comment 5 Simon Fraser (smfr) 2009-06-17 18:50:33 PDT
Comment on attachment 31468 [details]
Step 1 patch

Committed in http://trac.webkit.org/changeset/44794
Comment 6 Dave Hyatt 2009-06-18 11:12:20 PDT
Comment on attachment 31481 [details]
Step 2: hook up the MediaPlayer with the layer compositing system

r=me, make sure the VIDEO ifdefs are properly around everything.
Comment 7 Simon Fraser (smfr) 2009-06-18 11:53:03 PDT
http://trac.webkit.org/changeset/44809