WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26495
Upstream V8Index
https://bugs.webkit.org/show_bug.cgi?id=26495
Summary
Upstream V8Index
Nate Chapin
Reported
2009-06-17 15:32:05 PDT
Associated chromium issue:
http://crbug.com/14466
Attachments
patch
(42.29 KB, patch)
2009-06-17 15:34 PDT
,
Nate Chapin
dglazkov
: review+
Details
Formatted Diff
Diff
patch2
(43.05 KB, patch)
2009-06-18 10:35 PDT
,
Nate Chapin
dglazkov
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nate Chapin
Comment 1
2009-06-17 15:34:34 PDT
Created
attachment 31451
[details]
patch Associated chromium patch:
http://codereview.chromium.org/126296
Dimitri Glazkov (Google)
Comment 2
2009-06-17 21:54:52 PDT
Comment on
attachment 31451
[details]
patch This whole file is total sadness. But I'd rather land it so that we have them all in one place.
> +// FIXME: Can we use a macro to include necessary headers by using WRAPPER_TYPES?
Nah.
> + class V8ClassIndex { > + public: > + // Type must start at non-negative numbers. See ToInt, FromInt. > + enum V8WrapperType { > + INVALID_CLASS_INDEX = 0, > + > +#define DEFINE_ENUM(name, type) name, > + ALL_WRAPPER_TYPES(DEFINE_ENUM) > +#undef DEFINE_ENUM > + > + CLASSINDEX_END, > + WRAPPER_TYPE_COUNT = CLASSINDEX_END > + }; > + > + static int ToInt(V8WrapperType type) { return static_cast<int>(type); }
Add a FIXME to convert to toInt. I realize it will be near-impossible to refactor it before all of the bindings land in one place.
> + > + static V8WrapperType FromInt(int v) {
Ditto.
> + ASSERT(INVALID_CLASS_INDEX <= v && v < CLASSINDEX_END); > + return static_cast<V8WrapperType>(v); > + } > + > + static FunctionTemplateFactory GetFactory(V8WrapperType type);
Ditto.
> + // Returns a field to be used as cache for the template for the given type > + static v8::Persistent<v8::FunctionTemplate>* GetCache(V8WrapperType type);
Ditto.
David Levin
Comment 3
2009-06-18 01:24:48 PDT
Please pick up the latest changes to this file when checking in, so that the check in doesn't break the chromium build. I just changed this file downstream due HTMLDataEditGrid (I think it was called).
David Levin
Comment 4
2009-06-18 01:29:05 PDT
s/HTMLDataEditGrid/HTMLDataGridElement/
Nate Chapin
Comment 5
2009-06-18 10:35:16 PDT
Created
attachment 31502
[details]
patch2
David Levin
Comment 6
2009-06-25 10:10:27 PDT
Assign to japhet for landing.
Eric Seidel (no email)
Comment 7
2009-06-29 13:24:17 PDT
Does japhet@ have commit bit? I don't remember seeing his nomination go by... If not, then someone else will need to land this.
Nate Chapin
Comment 8
2009-06-29 13:26:35 PDT
I do, it was landed as
r45193
. Sorry for forgetting about my cleanup...
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug