Bug 26489 - Web Inspector: Typo in DatabaseQuery Error Message
Summary: Web Inspector: Typo in DatabaseQuery Error Message
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-17 11:49 PDT by Joseph Pecoraro
Modified: 2009-06-25 05:42 PDT (History)
0 users

See Also:


Attachments
Spelling corrections (27.55 KB, patch)
2009-06-17 11:58 PDT, Joseph Pecoraro
eric: review-
Details | Formatted Diff | Diff
ChangeLog + Typo Fix (28.24 KB, patch)
2009-06-24 19:46 PDT, Joseph Pecoraro
jmalonzo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2009-06-17 11:49:04 PDT
In the "Databases" Tab of the Web Inspector, in the Database Console for a particular Database, executing a query resulting in an error produces the following error message:

    "An unexpected error 0 occured."

"occured" is a typo, it should be "occurred"


I'm not too familiar with how these messages work.  I found:
WebCore/inspector/front-end/DatabaseQueryView.js
line 160: var message = WebInspector.UIString("An unexpected error %s occured.", error.code);

However those UIString gets a value from localizedStrings which I believe comes from:
WebCore/English.lproj/localizedStrings.js
line 36: localizedStrings["An unexpected error %s occured."] = "An unexpected error %s occured.";

I'm guessing all 3 places should be changed, but are there any other places that would need to be changed?
Comment 1 Joseph Pecoraro 2009-06-17 11:58:19 PDT
Created attachment 31429 [details]
Spelling corrections

First timer here, so hopefully I did it right.  It must think that English.lproj was a binary.
Comment 2 Eric Seidel (no email) 2009-06-24 18:57:13 PDT
Comment on attachment 31429 [details]
Spelling corrections

This change needs a ChangeLog.

See http://webkit.org/coding/contributing.html

Most notably:
http://webkit.org/coding/contributing.html#changelogs
Comment 3 Joseph Pecoraro 2009-06-24 19:46:23 PDT
Created attachment 31829 [details]
ChangeLog + Typo Fix

Ran a prepare-ChangeLog this time!
Comment 4 Jan Alonzo 2009-06-25 04:47:44 PDT
Comment on attachment 31829 [details]
ChangeLog + Typo Fix

r=me.
Comment 5 Jan Alonzo 2009-06-25 05:42:57 PDT
(In reply to comment #4)
> (From update of attachment 31829 [details] [review])
> r=me.
> 

Landed in r45173.