Bug 26489 – Web Inspector: Typo in DatabaseQuery Error Message

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

In the "Databases" Tab of the Web Inspector, in the Database Console for a particular Database, executing a query resulting in an error produces the following error message:

    "An unexpected error 0 occured."

"occured" is a typo, it should be "occurred"


I'm not too familiar with how these messages work.  I found:
WebCore/inspector/front-end/DatabaseQueryView.js
line 160: var message = WebInspector.UIString("An unexpected error %s occured.", error.code);

However those UIString gets a value from localizedStrings which I believe comes from:
WebCore/English.lproj/localizedStrings.js
line 36: localizedStrings["An unexpected error %s occured."] = "An unexpected error %s occured.";

I'm guessing all 3 places should be changed, but are there any other places that would need to be changed?

[Joseph Pecoraro]

Created attachment 31429 [details]
Spelling corrections

First timer here, so hopefully I did it right.  It must think that English.lproj was a binary.

[Eric Seidel (no email)]

Comment on attachment 31429 [details]
Spelling corrections

This change needs a ChangeLog.

See http://webkit.org/coding/contributing.html

Most notably:
http://webkit.org/coding/contributing.html#changelogs

[Joseph Pecoraro]

Created attachment 31829 [details]
ChangeLog + Typo Fix

Ran a prepare-ChangeLog this time!

[Jan Alonzo]

Comment on attachment 31829 [details]
ChangeLog + Typo Fix

r=me.

[Jan Alonzo]

(In reply to comment #4)
> (From update of attachment 31829 [details] [review])
> r=me.
> 

Landed in r45173.