RESOLVED FIXED 264859
Replace strongThis by protectedThis 
https://bugs.webkit.org/show_bug.cgi?id=264859
Summary Replace strongThis by protectedThis
Jean-Yves Avenard [:jya]
Reported 2023-11-14 20:19:37 PST
From webkit coding style: https://webkit.org/code-style-guidelines/#names-protectors-this "Ref and RefPtr objects meant to protect this from deletion should be named "protectedThis".
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-11-14 20:19:53 PST
<rdar://problem/118434279>
Fujii Hironori
Comment 2 2023-11-14 20:27:13 PST
Chris said we should update the style guideline in favor of the smart pointer guideline. > we can get rid of protectedThis from our codebase https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines
Chris Dumez
Comment 3 2023-11-14 20:28:30 PST
(In reply to Fujii Hironori from comment #2) > Chris said we should update the style guideline in favor of the smart > pointer guideline. > > > we can get rid of protectedThis from our codebase > > https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines Not in lambda captures, which I think is what Jean-Yves is talking about.
Jean-Yves Avenard [:jya]
Comment 4 2023-11-14 20:30:54 PST
Pull request: https://github.com/WebKit/WebKit/pull/20520
EWS
Comment 5 2023-11-15 00:16:47 PST
Committed 270757@main (c72b2982933d): <https://commits.webkit.org/270757@main> Reviewed commits have been landed. Closing PR #20520 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.