Bug 26484 – [CHROMIUM] ASSERT_NOT_REACHED reached in Chromium font code

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Nicolas Sylvain]

In the font code for chromium, we try to load font, and if it fails because of the sandbox, we ask the browser process to try to load it by calling ensureFontLoaded. If it still fails after ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

This case happens once in a while during browser shutdown. The browser will queue a message to the renderer to shutdown, and will then stop answering sync messages from the renderer. If the renderer is still loading a page during this time, it might try to call the browser process to ask to load a font. The browser process will ignore the request, and the font will fail to load, even after the second try.

This is unfortunate, but there is no real risk here, since the renderer will be going away as soon as it processes another message.

My proposal is to change  FontCacheChromiumWin.cpp:291
from:
ASSERT_NOT_REACHED();
to: 
LOG_ERROR("Unable to get the font unicode range after second attempt");

[Ojan Vafai]

Created attachment 31426 [details]
Replace assert with log.

 2 files changed, 26 insertions(+), 1 deletions(-)

[David Levin]

It looks like this was committed as http://trac.webkit.org/changeset/44770.

[Nicolas Sylvain]

I'm reopening this bug since I found another instance of this in Font::drawGlyphs. I'll submit a patch for review. (with a similar code change)

[Eric Seidel (no email)]

Please use a new bug.