RESOLVED FIXED 264808
[CMake] build-webkit script should check env var BUILD_WEBKIT_ARGS when checking if the cache should be cleaned 
https://bugs.webkit.org/show_bug.cgi?id=264808
Summary [CMake] build-webkit script should check env var BUILD_WEBKIT_ARGS when check...
Carlos Alberto Lopez Perez
Reported 2023-11-14 05:10:24 PST
The script build-webkit caches the parameters passed to it in order to clean the CMake cache if the developer changes those from one invocation to the next one. The issue is that we support passing parameters also via the environment variable BUILD_WEBKIT_ARGS (which we use on the bots) But we are not checking the values from this env var when deciding to clean the cache or not. So it happens that if you change this environment variable with new values the CMake cache will not be clean automatically.
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2023-11-14 05:15:21 PST
Pull request: https://github.com/WebKit/WebKit/pull/20477
EWS
Comment 2 2023-11-23 11:24:19 PST
Committed 271085@main (183e4e8088af): <https://commits.webkit.org/271085@main> Reviewed commits have been landed. Closing PR #20477 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-11-23 11:25:15 PST
<rdar://problem/118752244>
Note You need to log in before you can comment on or make changes to this bug.