WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264792
Use dynamicDowncast<T> even more in the DOM
https://bugs.webkit.org/show_bug.cgi?id=264792
Summary
Use dynamicDowncast<T> even more in the DOM
Chris Dumez
Reported
2023-11-13 21:49:39 PST
Use dynamicDowncast<T> even more in the DOM instead of is<T>() + downcast<T>(). It is less error-prone and often results in more concise code. I am also hoping to have downcast<>() do a type check on release builds in the future. It is currently too expensive to do so but it may become affordable if we use dynamicDowncast<T>() instead when possible.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-11-13 21:53:17 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20459
EWS
Comment 2
2023-11-14 08:59:52 PST
Committed
270710@main
(7b68c9b9e188): <
https://commits.webkit.org/270710@main
> Reviewed commits have been landed. Closing PR #20459 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-11-14 09:00:17 PST
<
rdar://problem/118398612
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug