Bug 264766 - wasm-omg test mode in stress tests should tier up to OMG immediately
Summary: wasm-omg test mode in stress tests should tier up to OMG immediately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-13 12:21 PST by Asumu Takikawa
Modified: 2023-11-13 20:36 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-11-13 12:21:46 PST 
Currently the wasm-omg test mode for stress tests does not tier up to OMG immediately.

For example, the following `run-jsc-stress-tests --debug --filter i31.js` *should* find an assertion failure in B3 that I found manually.

(the manual test run for comparison: `run-jsc --jsc-only --debug --useWebAssemblyGC=true --useWebAssemblyTypedFunctionReferences=true --useOMGJIT=true --useBBQJIT=false --thresholdForOMGOptimizeSoon=0 --thresholdForOMGOptimizeAfterWarmup=0 -m i31.js` while in `JSTests/wasm/gc`)

The run-jsc-stress-tests script needs some flags that will trigger an immediate tier-up. Possibly --thresholdForOMGOptimizeSoon=0 --thresholdForOMGOptimizeAfterWarmup=0 could work.
Comment 1 Asumu Takikawa 2023-11-13 13:50:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20438
Comment 2 EWS 2023-11-13 20:35:03 PST 
Committed 270685@main (e7f7e511899e): <https://commits.webkit.org/270685@main>

Reviewed commits have been landed. Closing PR #20438 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-13 20:36:15 PST 
<rdar://problem/118372154>