Bug 264735 – [import-w3c-tests] deleting generic -expected files when platform-specific baselines exist

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

https://github.com/WebKit/WebKit/pull/20412 started off with `./Tools/Scripts/import-w3c-tests -s ~/projects/wpt/wpt-clean --clean-dest-dir web-platform-tests/dom`, which deleted `LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window-expected.txt`. However, `LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window.html` still exists. This is wrong and bad.

[Radar WebKit Bug Importer]

<rdar://problem/118329279>

[Sam Sneddon [:gsnedders]]

(Pdb) 'imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window.html' in {test.test_path for test in tests}
True
(Pdb) 'imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window-expected.txt' in baselines_for_tests
False
(Pdb) pp self.port.expected_filename("imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window.html", ".txt")
'/Volumes/gsnedders/projects/Safari/OpenSource/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window-expected.txt'

We're confused because we have a baseline in the platform directory.

[Sam Sneddon [:gsnedders]]

Ah, because we always prune baselines, this doesn't actually require --clean-dest-dir.

Patch forthcoming.

[Sam Sneddon [:gsnedders]]

Pull request: https://github.com/WebKit/WebKit/pull/20603

[EWS]

Committed 270899@main (69c47f823b0e): <https://commits.webkit.org/270899@main>

Reviewed commits have been landed. Closing PR #20603 and removing active labels.