Bug 264687 - Sync 'RTCEncodedVideoFrame' and 'RTCEncodedAudioFrame' with WebIDL Specification
Summary: Sync 'RTCEncodedVideoFrame' and 'RTCEncodedAudioFrame' with WebIDL Specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-11-11 13:35 PST by Ahmad Saleem
Modified: 2024-06-20 04:24 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-11-11 13:35:10 PST
Hi Team,

While looking into IDLHarness failures on WPT, I noticed that we are failing a bunch of tests related to 'RTCEncodedVideoFrame' and 'RTCEncodedAudioFrame' and noticed that we are not exposing them to 'Window'.

Web-Spec (for Video): https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedVideoFrame-interface & https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedVideoFrameMetadata

and change to 'Exposed=(Window,DedicatedWorker)'

Web-Spec (for Audio): https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedAudioFrame-interface & https://www.w3.org/TR/webrtc-encoded-transform/#RTCEncodedAudioFrameMetadata

and change to 'Exposed=(Window,DedicatedWorker)'

___

It leads to 19 tests passes in following WPT test case:

Test Case: https://wpt.fyi/results/webrtc-encoded-transform/idlharness.https.window.html?label=master&label=experimental&aligned=

Test Case Live Link: https://wpt.live/webrtc-encoded-transform/idlharness.https.window.html

___

Just wanted to raise so we can fix it.

Thanks!
Comment 1 Ahmad Saleem 2023-11-11 13:57:09 PST
We need to import 'webrtc-encoded-transform' tests from WPT before doing this because we don't have 'idlharness' test in our test suite.
Comment 2 Radar WebKit Bug Importer 2023-11-18 13:36:14 PST
<rdar://problem/118607685>
Comment 3 EWS 2024-06-20 04:24:32 PDT
Committed 280198@main (b6d3b63a9d78): <https://commits.webkit.org/280198@main>

Reviewed commits have been landed. Closing PR #29981 and removing active labels.