WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
264586
Scroll bar uses dark mode based on overlay scrollbar when not using overlay scrollbar
https://bugs.webkit.org/show_bug.cgi?id=264586
Summary
Scroll bar uses dark mode based on overlay scrollbar when not using overlay s...
Pascal Abresch
Reported
2023-11-10 07:50:36 PST
Created
attachment 468554
[details]
Patch to check if overlay scrollbars are used As context, this bug has been discovered in the haikuwebkit port and fixed. On a page which has a dark background but does not use color-scheme with a value of dark the scrollbar will use the dark color. This is because webkit checks if the overlayscrollbar style is light, however this check also is done if the port does not use overlay scrollbars. I've attached the patch to fix this issue, please advice on how I can create a test that checks for the rendering for this issue. Regards
Attachments
Patch to check if overlay scrollbars are used
(1.13 KB, patch)
2023-11-10 07:50 PST
,
Pascal Abresch
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Bug reproduced on shipping Safari 17
(349.24 KB, image/png)
2023-11-14 02:08 PST
,
Abrar Rahman Protyasha
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Abrar Rahman Protyasha
Comment 1
2023-11-13 17:57:28 PST
Is there some website / page where you came across this bug?
Adrien Destugues
Comment 2
2023-11-14 00:11:55 PST
Some example websites:
https://pulkomandy.tk
- black background for the body element, but the page is otherwise light mode. In Haikuwebkit this results in a dark mode scrollbar
http://www.cantrell.org.uk/david/tech/cpc/cpc-firmware/
- blue background that is classified as "dark", so we get a dark mode scrollbar I don't know if the render themes for other platforms will take the scrollbar color into account for non-overlay scrollbars, so maybe the issue isn't visible on other platforms?
Abrar Rahman Protyasha
Comment 3
2023-11-14 02:08:10 PST
Created
attachment 468592
[details]
Bug reproduced on shipping Safari 17 Okay yeah, I totally see it on
http://www.cantrell.org.uk/david/tech/cpc/cpc-firmware/
. Thanks for the link!
Pascal Abresch
Comment 4
2023-11-14 06:54:48 PST
Is the cpc site the same bug? On iOS I am getting black overlay scrollbars, which would correspond to the overlayscrollbarstyle dark, which as I understand it is for light mode. The bug on pulkomamdys site is that it picks light overlay scrollbar style because the background is dark, and thus uses dark mode scrollbars for us. (which are white for overlayscrollbars since they need to contrast the background)
Radar WebKit Bug Importer
Comment 5
2023-11-17 07:51:13 PST
<
rdar://problem/118565009
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug