RESOLVED FIXED 26453
Null Cairo context will crash Windows Cairo Build 
https://bugs.webkit.org/show_bug.cgi?id=26453
Summary Null Cairo context will crash Windows Cairo Build
Brent Fulgham
Reported 2009-06-16 13:07:01 PDT
The DRT test suite identified a crash bug in the Windows Cairo build. If a null platform graphics context is passed to the GraphicsContext constructor, e.g., from Line 3724 in RenderBlock.cpp: GraphicsContext context((PlatformGraphicsContext*)0); The internal Windows Cairo sync function (which attempts to keep the Windows DC in sync with the Cairo one) will crash when it attempts to retrieve the Cairo surface from the null pointer (see Line 180 in GraphicsContextCairoWin.cpp): cairo_surface_t* surface = cairo_get_target(cr); The fix is to check for a null pointer before attempting to do so.
Attachments
Null check. (1.32 KB, patch)
2009-06-16 13:13 PDT, Brent Fulgham 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2009-06-16 13:13:02 PDT
Created attachment 31367 [details] Null check.
Xan Lopez
Comment 2 2009-06-16 13:24:04 PDT
Comment on attachment 31367 [details] Null check. r=me
Brent Fulgham
Comment 3 2009-06-16 13:31:25 PDT
Landed in http://trac.webkit.org/changeset/44734
Note You need to log in before you can comment on or make changes to this bug.