Bug 26450 - Rename values of enum RedirectOriginCheck to make them clearer.
: Rename values of enum RedirectOriginCheck to make them clearer.
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-16 11:39 PST by
Modified: 2009-06-16 14:01 PST (History)


Attachments
Proposed Patch (5.67 KB, patch)
2009-06-16 11:54 PST, Jian Li
levin: review-
Review Patch | Details | Formatted Diff | Diff
Proposed Patch (25.29 KB, patch)
2009-06-16 13:11 PST, Jian Li
levin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-16 11:39:48 PST
Rename enum value RequireSameRedirectOrigin to DenyCrossOriginRedirect, and AllowDifferentRedirectOrigin to AllowCrossOriginRedirect.
------- Comment #1 From 2009-06-16 11:54:55 PST -------
Created an attachment (id=31361) [details]
Proposed Patch
------- Comment #2 From 2009-06-16 12:33:28 PST -------
(From update of attachment 31361 [details])
How about CrossOriginRedirectPolicy as the enum name as it seems more consistent with the naming of the enums values?
------- Comment #3 From 2009-06-16 13:11:56 PST -------
Created an attachment (id=31366) [details]
Proposed Patch
------- Comment #4 From 2009-06-16 13:19:52 PST -------
(From update of attachment 31366 [details])
Thanks!
------- Comment #5 From 2009-06-16 14:01:52 PST -------
Committed as http://trac.webkit.org/changeset/44737