RESOLVED FIXED 26450
Rename values of enum RedirectOriginCheck to make them clearer. 
https://bugs.webkit.org/show_bug.cgi?id=26450
Summary Rename values of enum RedirectOriginCheck to make them clearer.
Jian Li
Reported 2009-06-16 11:39:48 PDT
Rename enum value RequireSameRedirectOrigin to DenyCrossOriginRedirect, and AllowDifferentRedirectOrigin to AllowCrossOriginRedirect.
Attachments
Proposed Patch (5.67 KB, patch)
2009-06-16 11:54 PDT, Jian Li 		levin: review-
DetailsFormatted DiffDiff
Proposed Patch (25.29 KB, patch)
2009-06-16 13:11 PDT, Jian Li 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-06-16 11:54:55 PDT
Created attachment 31361 [details] Proposed Patch
David Levin
Comment 2 2009-06-16 12:33:28 PDT
Comment on attachment 31361 [details] Proposed Patch How about CrossOriginRedirectPolicy as the enum name as it seems more consistent with the naming of the enums values?
Jian Li
Comment 3 2009-06-16 13:11:56 PDT
Created attachment 31366 [details] Proposed Patch
David Levin
Comment 4 2009-06-16 13:19:52 PDT
Comment on attachment 31366 [details] Proposed Patch Thanks!
Jian Li
Comment 5 2009-06-16 14:01:52 PDT
Committed as http://trac.webkit.org/changeset/44737
Note You need to log in before you can comment on or make changes to this bug.