Bug 264450 - [git-webkit] Handle multiple bugs associated with a single branch
Summary: [git-webkit] Handle multiple bugs associated with a single branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-08 16:13 PST by Jonathan Bedard
Modified: 2023-11-17 16:52 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-11-08 16:13:59 PST
When we set a branch config value in git-webkit, that value is appended to any existing value for that branch. On PR branches, this isn't a problem because the user should only have a single bug associated with the branch. But for cherry-picks, multiple cherry-picks are very likely to be done on the same branch. Since the oldest values come first, the commit message template will tend to prefer the older value to the newer ones. Our commit message template should prefer newer values to older ones, and generally, should not allow duplicates of the same value. "not allowing duplicates" is complicated by the fact that a user may store a newline delinated value, which will look like two independent values. This is particularly relevant for bugs.
Comment 1 Radar WebKit Bug Importer 2023-11-08 16:14:24 PST
<rdar://problem/118144919>
Comment 2 Jonathan Bedard 2023-11-08 16:22:25 PST
Pull request: https://github.com/WebKit/WebKit/pull/20200
Comment 3 EWS 2023-11-17 16:52:36 PST
Committed 270921@main (88a259f2f225): <https://commits.webkit.org/270921@main>

Reviewed commits have been landed. Closing PR #20200 and removing active labels.