Bug 264437 – AX: Caption and figure caption elements are ignored.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

.

[Radar WebKit Bug Importer]

<rdar://problem/118139030>

[Andres Gonzalez]

Created attachment 468521 [details]
Patch

[Tyler Wilcock]

Comment on attachment 468521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468521&action=review

> Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:-141
> -    if (roleValue() == AccessibilityRole::Caption && ariaRoleAttribute() == AccessibilityRole::Unknown)
> -        return AccessibilityObjectInclusion::IgnoreObject;

I assume this was ignored because the caption text is exposed automatically by moving focus to the table. By preventing it from being ignored, will there now be an extra stop that causes ATs like VoiceOver to speak the caption twice — once for the table, and once when focus moves to the caption? I'm less familiar with figcaption, but I have to imagine the idea was the same.

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 468521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468521&action=review
> 
> > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:-141
> > -    if (roleValue() == AccessibilityRole::Caption && ariaRoleAttribute() == AccessibilityRole::Unknown)
> > -        return AccessibilityObjectInclusion::IgnoreObject;
> 
> I assume this was ignored because the caption text is exposed automatically
> by moving focus to the table. By preventing it from being ignored, will
> there now be an extra stop that causes ATs like VoiceOver to speak the
> caption twice — once for the table, and once when focus moves to the
> caption? I'm less familiar with figcaption, but I have to imagine the idea
> was the same.

No, VO doesn't have an extra VO + arrow stop in table captions with this change.

[Andres Gonzalez]

Created attachment 468527 [details]
Patch

Updating test expectation for WK1

[EWS]

Committed 270467@main (30503bbfeadf): <https://commits.webkit.org/270467@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468527 [details].