Bug 264299 – [JSC] Use simpler helpers for repatching

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

...

[Radar WebKit Bug Importer]

<rdar://problem/118023749>

[Yusuke Suzuki]

Pull request: https://github.com/WebKit/WebKit/pull/20069

[EWS]

Committed 270351@main (f5d367e64491): <https://commits.webkit.org/270351@main>

Reviewed commits have been landed. Closing PR #20069 and removing active labels.

[Diego Pino]

Debian 11 bot is failing witht the following error:

https://build.webkit.org/#/builders/46/builds/34680

./../../Source/JavaScriptCore/assembler/X86Assembler.h: In static member function ‘static void JSC::X86Assembler::replaceWithNops(void*, size_t)’:
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: no matching function for call to ‘JSC::X86Assembler::fillNops<memcpy>(void*&, size_t&)’
 6396 |         fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes);
      |                                                                       ^
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note: candidate: ‘template<void* (& copy)(void*, const void*, size_t)> static void JSC::X86Assembler::fillNops(void*, size_t)’
 6513 |     static void fillNops(void* base, size_t size)
      |                 ^~~~~~~~
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note:   template argument deduction/substitution failed:
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: ‘(void* (&)(void*, const void*, size_t))memcpy’ is not a valid template argument for type ‘void* (&)(void*, const void*, size_t)’ {aka ‘void* (&)(void*, const void*, long unsigned int)’}
 6396 |         fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes);

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/20220

[EWS]

Committed 270526@main (32983feb344b): <https://commits.webkit.org/270526@main>

Reviewed commits have been landed. Closing PR #20220 and removing active labels.