Bug 264299 - [JSC] Use simpler helpers for repatching
Summary: [JSC] Use simpler helpers for repatching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-06 15:41 PST by Yusuke Suzuki
Modified: 2023-11-10 05:05 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2023-11-06 15:41:14 PST
...
Comment 1 Radar WebKit Bug Importer 2023-11-06 15:41:29 PST
<rdar://problem/118023749>
Comment 2 Yusuke Suzuki 2023-11-06 15:43:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/20069
Comment 3 EWS 2023-11-07 13:48:53 PST
Committed 270351@main (f5d367e64491): <https://commits.webkit.org/270351@main>

Reviewed commits have been landed. Closing PR #20069 and removing active labels.
Comment 4 Diego Pino 2023-11-09 01:29:40 PST
Debian 11 bot is failing witht the following error:

https://build.webkit.org/#/builders/46/builds/34680

./../../Source/JavaScriptCore/assembler/X86Assembler.h: In static member function ‘static void JSC::X86Assembler::replaceWithNops(void*, size_t)’:
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: no matching function for call to ‘JSC::X86Assembler::fillNops<memcpy>(void*&, size_t&)’
 6396 |         fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes);
      |                                                                       ^
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note: candidate: ‘template<void* (& copy)(void*, const void*, size_t)> static void JSC::X86Assembler::fillNops(void*, size_t)’
 6513 |     static void fillNops(void* base, size_t size)
      |                 ^~~~~~~~
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6513:17: note:   template argument deduction/substitution failed:
../../../Source/JavaScriptCore/assembler/X86Assembler.h:6396:71: error: ‘(void* (&)(void*, const void*, size_t))memcpy’ is not a valid template argument for type ‘void* (&)(void*, const void*, size_t)’ {aka ‘void* (&)(void*, const void*, long unsigned int)’}
 6396 |         fillNops<memcpy>(instructionStart, memoryToFillWithNopsInBytes);
Comment 5 Diego Pino 2023-11-09 01:34:10 PST
Re-opening for pull request https://github.com/webkit/webkit/pull/20220
Comment 6 EWS 2023-11-10 05:05:06 PST
Committed 270526@main (32983feb344b): <https://commits.webkit.org/270526@main>

Reviewed commits have been landed. Closing PR #20220 and removing active labels.