Bug 26427 - Use consistent Windows GUID Comparison Functions
Summary: Use consistent Windows GUID Comparison Functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-15 21:20 PDT by Brent Fulgham
Modified: 2009-06-16 09:44 PDT (History)
0 users

See Also:

Attachments
Use IsEqualGUID (2.20 KB, patch)
2009-06-15 21:25 PDT, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2009-06-15 21:20:28 PDT 
There are a handful of places where GUIDs are being compared using standard equality operator.

These should be changed to the SDK IsEqualGUID call.
Comment 1 Brent Fulgham 2009-06-15 21:25:50 PDT 
Created attachment 31331 [details]
Use IsEqualGUID
Comment 2 Darin Adler 2009-06-15 23:04:26 PDT 
Comment on attachment 31331 [details]
Use IsEqualGUID

> -    if (IID_IUnknown==riid || IID_IDataObject==riid)
> +    if (IsEqualIID(riid, IID_IUnknown) || 
> +        IsEqualIID(riid, IID_IDataObject)) {
>          *ppvObject=this;
> +    }

I don't think you needed to break this into multiple lines. And when you did, I wish you had followed the WebKit coding style (see the Indentation section, item 6, and the Braces section, item 3).

r=me
Comment 3 Brent Fulgham 2009-06-16 09:44:57 PDT 
Fixed line break and braces while landing.

Landed in http://trac.webkit.org/changeset/44723