RESOLVED FIXED 264241
Remove namespace std overloads of isnan, isinf, and infinite for WTF time types 
https://bugs.webkit.org/show_bug.cgi?id=264241
Summary Remove namespace std overloads of isnan, isinf, and infinite for WTF time types
Gerald Squelart
Reported 2023-11-06 00:06:26 PST
Time types under WTF (MonotonicTime, etc.) add overloads of std::isnan, isinf, and isfinite, but it is generally UB to add declarations&definitions to `namespace std`: https://en.cppreference.com/w/cpp/language/extending_std Instead, these functions should be class member functions, or free functions outside of `std`. I don't believe these functions are used in generic code, so I think member functions are more appropriate here.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-11-06 00:06:34 PST
<rdar://problem/117986797>
Gerald Squelart
Comment 2 2023-11-06 00:08:40 PST
Pull request: https://github.com/WebKit/WebKit/pull/20026
EWS
Comment 3 2023-11-07 20:02:03 PST
Committed 270366@main (acfb618b4d5a): <https://commits.webkit.org/270366@main> Reviewed commits have been landed. Closing PR #20026 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.