Bug 264234 - Remove Quirk shouldDisableContentChangeObserver() for YouTube.com
Summary: Remove Quirk shouldDisableContentChangeObserver() for YouTube.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari 17
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL: https://youtube.com/
Keywords: InRadar
Depends on: 195295 249740 263789
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-05 17:17 PST by Karl Dubost
Modified: 2023-11-06 00:23 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2023-11-05 17:17:40 PST
Usually to be able to check if the site is without quirks, it is necessary to disable the Quirk with the Web Inspector opened. 
Unfortunately in this specific case, opening the Web Inspector also resolves the issue.

This bug is to fully remove the Quirk that was 
* put in place by Bug 249740 
* then extended by Bug 263789

The user had to tap a number of times or wait for a long time to expect the tap on iPad Pro or click on VisionPro to take effect.

After outreach to YouTube, they changed the way to handle the events so that the issue doesn't exist on the full Website. 
The Quirk is not needed anymore. 
https://searchfox.org/wubkat/rev/023c54054092dc68c5df3b230ed3137cbd753b16/Source/WebCore/page/Quirks.cpp#196-204
Comment 1 Radar WebKit Bug Importer 2023-11-05 17:18:11 PST
<rdar://problem/117975999>
Comment 2 Karl Dubost 2023-11-05 19:07:14 PST
Pull request: https://github.com/WebKit/WebKit/pull/20020
Comment 3 EWS 2023-11-06 00:23:42 PST
Committed 270256@main (995ab8e86662): <https://commits.webkit.org/270256@main>

Reviewed commits have been landed. Closing PR #20020 and removing active labels.