Bug 26423 - Expanding profile call stacks broken after sorting
Summary: Expanding profile call stacks broken after sorting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Timothy Hatcher
URL: http://webkit.org/misc/drosera/
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-15 16:12 PDT by Timothy Hatcher
Modified: 2009-09-24 19:21 PDT (History)
5 users (show)

See Also:


Attachments
Tell collapsed grid nodes with children to refresh the children on the next expand (1.63 KB, patch)
2009-09-24 18:34 PDT, Jessie Berlin
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2009-06-15 16:12:56 PDT
Sometimes expanding a call stack will not show any decendants.

Steps:
1) Load http://webkit.org/misc/drosera/
2) Enable profiling in the Inspector.
3) Click "Nested functions" button.
4) View the profile.
5) Expand then colapse the "rot" call.
6) Sort by Calls.
7) Try to expand the same "rot" call.

Results: Disclosure triangle expands but no decendancts show up.
Expected: The decendancts should show up in the rows below.

This might be a bug in DataGrid.js.
Comment 1 Jessie Berlin 2009-09-24 18:34:25 PDT
Created attachment 40096 [details]
Tell collapsed grid nodes with children to refresh the children on the next expand
Comment 2 Timothy Hatcher 2009-09-24 18:40:26 PDT
Comment on attachment 40096 [details]
Tell collapsed grid nodes with children to refresh the children on the next expand

Nice! (You have tabs in your ChangeLog.)
Comment 3 Jessie Berlin 2009-09-24 19:21:05 PDT
Thanks!

Removed the tabs and committed: http://trac.webkit.org/changeset/48742