Bug 264229 - markAllBackingStoreVolatileFromTimer can stop the volatility timer too soon
Summary: markAllBackingStoreVolatileFromTimer can stop the volatility timer too soon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-05 12:47 PST by Matt Woodrow
Modified: 2023-11-09 15:50 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-11-05 12:47:04 PST 
<rdar://116711724>

RemoteLayerWithRemoteRenderingBackingStoreCollection::markAllBackingStoreVolatileFromTimer stops the volatility timer if the operation is successful, since there should be no further backing stores to mark volatile.

This is an async operation though, and it's possible for markBackingStoreVolatileAfterReachabilityChange to have been called in the interim and there are now new backing stores that aren't yet volatile.
Comment 1 Matt Woodrow 2023-11-05 12:49:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/20014
Comment 2 EWS 2023-11-09 15:50:36 PST 
Committed 270486@main (a6666b946bcc): <https://commits.webkit.org/270486@main>

Reviewed commits have been landed. Closing PR #20014 and removing active labels.