WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264207
Build failure of AccessibilityNotificationHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=264207
Summary
Build failure of AccessibilityNotificationHandler.cpp
ChangSeok Oh
Reported
2023-11-04 09:56:21 PDT
I don't know why this happens to me now. I got a build failure on AccessibilityNotificationHandler.cpp $ Tools/Scripts/build-webkit --gtk --makeargs="-j7" ``` /app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:50:46: error: no member named 'addNotificationObserver' in 'WebCore::Accessib ilityAtspi' WebCore::AccessibilityAtspi::singleton().addNotificationObserver(this, [this](WebCore::AccessibilityObjectAtspi& element, const char* notificationName, WebCore::Acces sibilityAtspi::NotificationObserverParameter parameter) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:50:186: error: no type named 'NotificationObserverParameter' in 'WebCore::Acc essibilityAtspi' WebCore::AccessibilityAtspi::singleton().addNotificationObserver(this, [this](WebCore::AccessibilityObjectAtspi& element, const char* notificationName, WebCore::Acces sibilityAtspi::NotificationObserverParameter parameter) { ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~^ /app/webkit/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:95:46: error: no member named 'removeNotificationObserver' in 'WebCore::Acces sibilityAtspi' WebCore::AccessibilityAtspi::singleton().removeNotificationObserver(this); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ 3 errors generated. [5289/5406] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWebCore.dir/Tests/WebCore/TransformationMatrix.cpp.o ``` The constructor and destructor of AccessibilityNotificationHandler use AccessibilityAtspi's methods guarded by DEVELOPER_MODE.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-11-04 09:56:29 PDT
<
rdar://problem/117946319
>
ChangSeok Oh
Comment 2
2023-11-04 10:03:11 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19999
ChangSeok Oh
Comment 3
2023-11-04 10:06:39 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/20000
EWS
Comment 4
2023-11-07 10:00:28 PST
Committed
270333@main
(0335988960fa): <
https://commits.webkit.org/270333@main
> Reviewed commits have been landed. Closing PR #20000 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug