RESOLVED FIXED264146
[MSE] MediaSource::isEnded is unnecessarily passed to all methods 
https://bugs.webkit.org/show_bug.cgi?id=264146
Summary [MSE] MediaSource::isEnded is unnecessarily passed to all methods
Jean-Yves Avenard [:jya]
Reported 2023-11-03 03:26:41 PDT
sub-task of bug 264134 Whenever a method is called in the SourceBufferPrivate, the value of MediaSource::isEnded() is passed. But the MediaSourcePrivate was already notified that the MediaSource has been ended and each SourceBufferPrivate keep a reference to the MediaSourcePrivate. So we can simplify the code and remove some unnecessary methods.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-11-03 03:27:18 PDT
<rdar://problem/117899460>
Jean-Yves Avenard [:jya]
Comment 2 2023-11-03 03:44:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19940
EWS
Comment 3 2023-11-08 08:04:13 PST
Committed 270390@main (b21ca9944221): <https://commits.webkit.org/270390@main> Reviewed commits have been landed. Closing PR #19940 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.