Bug 264103 - getComputedStyle() should work with functional pseudo-elements like ::highlight()
Summary: getComputedStyle() should work with functional pseudo-elements like ::highlig...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anne van Kesteren
URL:
Keywords: InRadar
: 269416 (view as bug list)
Depends on: 269743
Blocks:
  Show dependency tree / graph
 
Reported: 2023-11-02 11:26 PDT by Tim Nguyen (:ntim)
Modified: 2024-02-26 06:01 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-11-02 11:26:23 PDT 
Spec: https://www.w3.org/TR/css-pseudo-4/#getComputedStyle

WPT:
https://wpt.fyi/results/css/css-highlight-api?label=master&label=experimental&aligned&q=computed


Implementation notes:
Anywhere we take a PseudoId from CSSComputedStyleDeclaration to ComputedStyleExtractor to Element::computedStyle(), etc. we should pass a PseudoElementRequest instead of a PseudoId
CSSComputedStyleDeclaration would also need to convert from a String to a PseudoElementRequest instead of PseudoId
Comment 1 Radar WebKit Bug Importer 2023-11-02 11:26:38 PDT 
<rdar://problem/117864743>
Comment 2 Anne van Kesteren 2024-01-02 01:45:38 PST 
The parser side of this we want to do in CSSSelector::parseStandalonePseudoElement these days.
Comment 3 Anne van Kesteren 2024-02-15 06:17:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24510
Comment 4 EWS 2024-02-16 10:00:33 PST 
Committed 274846@main (2a9c86135d14): <https://commits.webkit.org/274846@main>

Reviewed commits have been landed. Closing PR #24510 and removing active labels.
Comment 5 WebKit Commit Bot 2024-02-19 13:06:09 PST 
Re-opened since this is blocked by bug 269743
Comment 6 Anne van Kesteren 2024-02-20 10:24:56 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24824
Comment 7 EWS 2024-02-20 13:52:34 PST 
Committed 275068@main (494280aef6da): <https://commits.webkit.org/275068@main>

Reviewed commits have been landed. Closing PR #24824 and removing active labels.
Comment 8 Anne van Kesteren 2024-02-26 06:01:06 PST 
*** Bug 269416 has been marked as a duplicate of this bug. ***