WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
263905
build-webkit --minimal option has bitrotted
https://bugs.webkit.org/show_bug.cgi?id=263905
Summary
build-webkit --minimal option has bitrotted
Philip Chimento
Reported
2023-10-30 10:54:29 PDT
I tried building a recent checkout with `build-webkit --gtk --minimal --notifications --service-worker`, and encountered a bunch of compile and link errors due to missing preprocessor guards, or headers needed in one file that were pulled in through another file behind a preprocessor guard. I've prepared a PR with fixes for these errors, that should get --minimal close to working again, at least for the GTK port.
Attachments
Add attachment
proposed patch, testcase, etc.
Philip Chimento
Comment 1
2023-10-30 12:14:33 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/19732
EWS
Comment 2
2023-11-02 00:28:12 PDT
Committed
270103@main
(cfc4a23cc201): <
https://commits.webkit.org/270103@main
> Reviewed commits have been landed. Closing PR #19732 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-11-02 00:29:16 PDT
<
rdar://problem/117837817
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug