Bug 26385 - Root SVG element is not checked on requiredFeatures, requiredExtension like other elements
Summary: Root SVG element is not checked on requiredFeatures, requiredExtension like o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-14 10:53 PDT by Rob Buis
Modified: 2009-06-18 12:51 PDT (History)
1 user (show)

See Also:

Attachments
First attempt (3.88 KB, patch)
2009-06-14 10:58 PDT, Rob Buis 		zimmermann: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2009-06-14 10:53:26 PDT 
If on the root SVG element requiredFeatures or any of the other test attributes is set, they are not taken into account. I checked in FF and Opera and there they are taken into account.
Comment 1 Rob Buis 2009-06-14 10:58:24 PDT 
Created attachment 31266 [details]
First attempt
Comment 2 Nikolas Zimmermann 2009-06-18 10:23:57 PDT 
Comment on attachment 31266 [details]
First attempt

Ouch, good catch! r=me.
Comment 3 Rob Buis 2009-06-18 11:45:00 PDT 
Thanks! Landed in r44808.
Comment 4 Darin Adler 2009-06-18 11:46:37 PDT 
This kind of virtual function override in a leaf class should normally be private rather than public.