RESOLVED FIXED 263849
AX: AXIsolatedObject tries to cache AXPropertyName::IsPressed on macOS despite it never being used 
https://bugs.webkit.org/show_bug.cgi?id=263849
Summary AX: AXIsolatedObject tries to cache AXPropertyName::IsPressed on macOS despit...
Tyler Wilcock
Reported 2023-10-29 10:09:32 PDT
This is a waste of CPU time.
Attachments
Patch (3.37 KB, patch)
2023-10-29 10:18 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-10-29 10:09:40 PDT
<rdar://problem/117653849>
Tyler Wilcock
Comment 2 2023-10-29 10:18:31 PDT
Created attachment 468402 [details] Patch
chris fleizach
Comment 3 2023-10-29 13:13:44 PDT
Should the Mac be using this? There is an aria-pressed attribute
Tyler Wilcock
Comment 4 2023-10-29 13:24:47 PDT
(In reply to chris fleizach from comment #3) > Should the Mac be using this? There is an aria-pressed attribute The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's sufficient.
Tyler Wilcock
Comment 5 2023-10-29 13:29:51 PDT
(In reply to Tyler Wilcock from comment #4) > (In reply to chris fleizach from comment #3) > > Should the Mac be using this? There is an aria-pressed attribute > The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's > sufficient. Though maybe the checkboxOrRadioValue() should also be checking Element::active() like isPressed() does? Would need to investigate further, it's not clear that's the right thing to do. I think this an improvement for now though.
EWS
Comment 6 2023-10-29 15:33:12 PDT
Committed 269916@main (3c509adf5677): <https://commits.webkit.org/269916@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468402 [details].
Note You need to log in before you can comment on or make changes to this bug.