Bug 263849 - AX: AXIsolatedObject tries to cache AXPropertyName::IsPressed on macOS despite it never being used
Summary: AX: AXIsolatedObject tries to cache AXPropertyName::IsPressed on macOS despit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-29 10:09 PDT by Tyler Wilcock
Modified: 2023-10-29 15:33 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2023-10-29 10:18 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-10-29 10:09:32 PDT 
This is a waste of CPU time.
Comment 1 Radar WebKit Bug Importer 2023-10-29 10:09:40 PDT 
<rdar://problem/117653849>
Comment 2 Tyler Wilcock 2023-10-29 10:18:31 PDT 
Created attachment 468402 [details]
Patch
Comment 3 chris fleizach 2023-10-29 13:13:44 PDT 
Should the Mac be using this? There is an aria-pressed attribute
Comment 4 Tyler Wilcock 2023-10-29 13:24:47 PDT 
(In reply to chris fleizach from comment #3)
> Should the Mac be using this? There is an aria-pressed attribute
The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's sufficient.
Comment 5 Tyler Wilcock 2023-10-29 13:29:51 PDT 
(In reply to Tyler Wilcock from comment #4)
> (In reply to chris fleizach from comment #3)
> > Should the Mac be using this? There is an aria-pressed attribute
> The Mac does use aria-pressed via checkboxOrRadioValue(), so I think that's
> sufficient.
Though maybe the checkboxOrRadioValue() should also be checking Element::active() like isPressed() does? Would need to investigate further, it's not clear that's the right thing to do. I think this an improvement for now though.
Comment 6 EWS 2023-10-29 15:33:12 PDT 
Committed 269916@main (3c509adf5677): <https://commits.webkit.org/269916@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468402 [details].