RESOLVED FIXED 263796
Adopt smart pointers in FrameLoader 
https://bugs.webkit.org/show_bug.cgi?id=263796
Summary Adopt smart pointers in FrameLoader
Chris Dumez
Reported 2023-10-27 12:47:48 PDT
Adopt smart pointers in FrameLoader.
Attachments
Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2023-10-27 16:44:27 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19665
EWS
Comment 2 2023-10-28 18:50:04 PDT
Committed 269901@main (af1e21c6dbce): <https://commits.webkit.org/269901@main> Reviewed commits have been landed. Closing PR #19665 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-10-28 18:51:14 PDT
<rdar://problem/117637326>
Diego Pino
Comment 4 2023-10-30 04:07:37 PDT
WebKitGTK Ubuntu LTS build bot, as well as other Ubuntu/Debian, build bots is failing with the following error after this commit: ``` FAILED: /home/buildbot/worker/GTK-Linux-64-bit-Release-Ubuntu-LTS-Build/build/Source/WebCore/loader/FrameLoader.cpp:3600:42: error: class template placeholder ‘WTF::CheckedPtr’ not permitted in this context 3600 | ForbidPromptsScope forbidPrompts(CheckedPtr { m_frame->page() }.get()); ```
Diego Pino
Comment 5 2023-10-30 04:11:05 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/19709
Note You need to log in before you can comment on or make changes to this bug.