Bug 263775 - [Nicosia] Simplify NicosiaPlatformLayer
Summary: [Nicosia] Simplify NicosiaPlatformLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-27 06:07 PDT by Carlos Garcia Campos
Modified: 2023-10-30 23:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-10-27 06:07:08 PDT 
We currently have generic classes that are created with a factory that creates the actual implementation. We only have one implementation, so we can just remove the unnecessary abstraction to save heap allocations, avoid casts and make the code easier to read.
Comment 1 Carlos Garcia Campos 2023-10-27 06:14:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19637
Comment 2 EWS 2023-10-30 23:00:02 PDT 
Committed 269998@main (ee8fbcb55b4a): <https://commits.webkit.org/269998@main>

Reviewed commits have been landed. Closing PR #19637 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-30 23:01:15 PDT 
<rdar://problem/117722993>