Bug 26377 – [GTK] Confusion about range of 'progress' property

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

The definition of the property 'progress' in WebKitWebView says it goes from 0.0 to 1.0:

    g_object_class_install_property(objectClass, PROP_PROGRESS,
                                    g_param_spec_double("progress",
                                                        "Progress",
                                                        "Determines the current progress of the load",
                                                        0.0, 1.0, 1.0,
                                                        WEBKIT_PARAM_READABLE));

But its actual implementation uses 0.0 to 100.0:

gdouble webkit_web_view_get_progress(WebKitWebView* webView)
{
    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), 1.0);

    return lround(core(webView)->progress()->estimatedProgress() * 100);
}

Notice that even in the same function the error/default value is 1.0 !

[Xan Lopez]

Created attachment 31292 [details]
progress.patch

Do not multiply the value in get_progress by 100.

[Xan Lopez]

Created attachment 31293 [details]
progress.patch

Ehm, get rid of the lround too, it's useless.

[Gustavo Noronha (kov)]

Comment on attachment 31293 [details]
progress.patch

Yep!

[Xan Lopez]

Thanks, landed as r44694.